Hi Jean,

> > From: Michal Simek <[EMAIL PROTECTED]>
> > 
> > there are some long lines in config file
> > but this patches clean a lot of coding style issues
> > 
> > There could be small problem with Daniel name.
> > Please check it in merge
> > 
> > Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
> > ---
> >  include/configs/sc520_spunk.h |  138
> +++++++++++++++++++----------------------
> >  1 files changed, 63 insertions(+), 75 deletions(-)
> > 
> > diff --git a/include/configs/sc520_spunk.h b/include/configs/sc520_spunk.h
> > index 051b2e0..179ecdf 100644
> > --- a/include/configs/sc520_spunk.h
> > +++ b/include/configs/sc520_spunk.h
> > @@ -1,6 +1,6 @@
> >  /*
> >   * (C) Copyright 2002
> > - * Daniel Engstr?m, Omicron Ceti AB, [EMAIL PROTECTED]
> > + * Daniel Engstr�m, Omicron Ceti AB, [EMAIL PROTECTED]
> >   *
> >   * See file CREDITS for list of people who contributed to this
> >   * project.
> > @@ -12,7 +12,7 @@
> >   *
> >   * This program is distributed in the hope that it will be useful,
> >   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.     See the
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> Please do not modify generic licence header

This is absurd tab in header which should be removed from all licenses in 
U-BOOT.


> >   * GNU General Public License for more details.
> >   *
> >   * You should have received a copy of the GNU General Public License
> > @@ -33,38 +33,36 @@
> >   * (easy to change)
> >   */
> >  #define CONFIG_BOOTDELAY   15
> > -#define CONFIG_BOOTARGS            "root=/dev/mtdblock1 console=ttyS0,9600 
> > " \
> > -                                   "mtdparts=phys:7936k(root),256k(uboot) "
> > -#define CONFIG_BOOTCOMMAND "setenv bootargs root=/dev/nfs ip=autoconf " \
> > -                                   "console=ttyS0,9600 " \
> > -                                   
> > "mtdparts=phys:7808k(root),128k(env),256k(uboot);" \
> > -                                   "bootp;bootm"
> > +#define CONFIG_BOOTARGS            "root=/dev/mtdblock1 console=ttyS0,9600
> mtdparts=phys:7936k(root),256k(uboot) "
> > +#define CONFIG_BOOTCOMMAND "setenv bootargs root=/dev/nfs ip=autoconf
> console=ttyS0,9600 mtdparts=phys:7808k(root),128k(env),256k(uboot); bootp;
> bootm"
> too long, please let the previous way

I know there are some long lines.

M


> >  
> >  #if defined(CONFIG_CMD_KGDB)
> >  #define CONFIG_KGDB_BAUDRATE       115200          /* speed to run kgdb 
> > serial port */
> >  #define CONFIG_KGDB_SER_INDEX      2               /* which serial port to 
> > use */
> >  #endif
> 
> Please be carreful about the 80 characters limits
> 
> Best Regards,
> J.
> 
> 
> 

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to