On Mon, Jul 28, 2008 at 10:03:43PM +0200, Jean-Christophe PLAGNIOL-VILLARD
wrote:
>
> +
> > +static const struct sdram_config sdram_config = {
> > + .data_bits = SDRAM_DATA_16BIT,
> > + .row_bits = 13,
> > + .col_bits = 9,
> > + .bank_bits = 2,
> > + .cas = 3,
> > + .twr = 2,
> > + .trc = 6,
> > + .trp = 2,
> > + .trcd = 2,
> > + .tras = 6,
> > + .txsr = 6,
> ^^^^^^^^
> please indent with tab for all files
That's not indenting, that's alignment -- or would be, if it were
actually aligned. :-P
Aligning with TABs (or at all, in initializer lists) is not a good thing,
IMO -- it screws things up when viewed with any other tab size (and why
else have tabs in the first place?).
> > +int spi_cs_is_valid(unsigned int bus, unsigned int cs)
> > +{
> > + return bus == 0 && cs == 0;
> please replace by
> return (bus == 0) && (cs == 0);
Why? This isn't typical coding style as far as I've seen.
-Scott
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
