Hi all I have just prepared, tested and sent a patch.
Best regards On Tue, Jul 29, 2008 at 4:59 PM, Stefan Roese <[EMAIL PROTECTED]> wrote: > Hi Wolfgang, > > On Tuesday 29 July 2008, Wolfgang Denk wrote: >> In message <[EMAIL PROTECTED]> you wrote: >> > > > #define CFG_MBYTES_SDRAM 256 >> > > >> > > No. All boards, especially all PowerPC boards, should use dynamic >> > > memory size detection. >> > >> > You are probably referring to calling get_ram_size() instead of just >> > returning the configured fixed value. But what do we gain here. >> > get_ram_size() also needs the ram-size as parameter. Not sure if this is >> > an improvement on such fixed systems. >> >> It just needs a maximum possible size. > > OK, this would be the 256 MB from above again. > >> One major advantage is for example that get_ram_size() verifies that >> RAM is actually working, and of expected size. It is a very efficient >> test to make sure your hardware is actually working. > > But what exactly should happen if such a board with only one possible memory > size configuration detects ram_size != configured ram_size? > > OK, this small check is an improvement over no check at all. Is it acceptable > that I add this get_ram_size() with an additional patch? This would safe me > from resetting my "next" branch or reverting patches. > > Best regards, > Stefan > > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] > ===================================================================== > -- Ricardo Ribalda http://www.eps.uam.es/~rribalda/ ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
