In message <[EMAIL PROTECTED]> you wrote:
> Hi all,
> This patch is to enable 2D Engine in SM501 video chip to hurry up fresh
> speed. It change some 2D Engine registers and could obviously fasten screen
> scroll up. I think it's reasonable to do it for consumerism.
Your line is way too long.
What exactly is "fresh speed"?
For "consumerism" ?
> commit 02e99b0a871f91fd3598024a2468a059971ef28d
> Parent: 699f05125509249072a0b865c8d35520d97cd501
> Author: Ryan Chen <[EMAIL PROTECTED]>
> Date: Wed Jul 30 09:45:01 2008 -0400
>
> Signed-off-by: Ryan Chen <[EMAIL PROTECTED]>
>
> modified: drivers/video/sm501.c
Please format your patches using git-format-patch and make sure to
supply a reasonable comit message.
Your patch adds a lot of code that may or may not be needed on some
systems. Please make it optional using a CONFIG_ option.
> diff --git a/drivers/video/sm501.c b/drivers/video/sm501.c
> old mode 100644
> new mode 100755
Please do not set exec permissions on plain source files.
> index 23db02c..f20cf94
> --- a/drivers/video/sm501.c
> +++ b/drivers/video/sm501.c
> @@ -35,6 +35,7 @@
>
> #include <video_fb.h>
> #include <sm501.h>
> +#include <asm/io.h>
What is this needed for?
...
> +/* Program new power mode. */
> +static void setPower(unsigned long nGates, unsigned long Clock)
> +{
> + unsigned long gate_reg, clock_reg;
> + unsigned long control_value;
> + u32 i;
> +
> + /* Get current power mode. */
> + control_value = FIELD_GET(read32(POWER_MODE_CTRL),
> + POWER_MODE_CTRL,
> + MODE);
> +
> + switch (control_value)
> + {
Coding Style:
switch (control_value) {
> + switch (bpp)
> + {
Ditto...
> +#if defined CONFIG_MULTI_VIDEO_CARD
> +void *sm501_video_hw_init (void)
> +#else
> void *video_hw_init (void)
> +#endif
This seems to be an unrelated change that should be plit into a
separate patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
He had quite a powerful intellect, but it was as powerful like a
locomotive, and ran on rails and was therefore almost impossible to
steer. - Terry Pratchett, _Lords and Ladies_
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
