Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> > In order to not introduce new warnings on the aforementioned three
> > architectures as well as i386, I added a cast to unsigned long. This
> > should be safe even if bi_baudrate is declared as 'int' (assuming
> > there's no such thing as negative baud rates.)  
> 
> Instead of the cast, should we not rather fix ARM, BF and MIPS to use
> ulong like anybody else?

Yeah, that's probably better. But I don't know what sort of side
effects that kind of change might cause. There could be code somewhere
that needs bi_baudrate to be signed for some obscure reason.

But if you're ok with it and people are willing to test, I can
certainly make that change.

Haavard

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to