In message <[EMAIL PROTECTED]> you wrote: > Hi all, > This patch is part 2 for [PATCH:Enable 2D Engine in SM501]. New macro > "CONFIG_SM501_ENABLE_2DENGINE" be included to specify codes what enable SM501 > 2D engine. The macro need be declared in config header file. > Why does it need to enable 2D engine? The reason is most of framebuffer > contents need be moved in VRAM when screen scrolls up. The work be done by > software in current U-Boot for SM501. The patch is to enable 2D engine to do > it by hardware without CPU in > terference. > > Signed-off-by: Ryan Chen <[EMAIL PROTECTED]>
Please rework the commit message, and use shorter lines (maximum some 70+ characters per line). There are also some coding style violations: trailing white space, indentation/vertical alignment by spaces instead of TABs, ... > + > +#define POWER_MODE0_CLOCK 0x000044 > +#define POWER_MODE0_CLOCK_PLL3_P1XCLK > 31:31 > +#define POWER_MODE0_CLOCK_PLL3_P1XCLK_ENABLE 1 > +#define POWER_MODE0_CLOCK_PLL3_P1XCLK_DISABLE 0 > +#define POWER_MODE0_CLOCK_PLL3 > 30:30 > +#define POWER_MODE0_CLOCK_PLL3_ENABLE > 1 > +#define POWER_MODE0_CLOCK_PLL3_DISABLE > 0 Corrupted alignment here? > +#define POWER_MODE1_CLOCK 0x00004C > +#define POWER_MODE1_CLOCK_PLL3_P1XCLK > 31:31 > +#define POWER_MODE1_CLOCK_PLL3_P1XCLK_ENABLE 1 > +#define POWER_MODE1_CLOCK_PLL3_P1XCLK_DISABLE 0 > +#define POWER_MODE1_CLOCK_PLL3 > 30:30 > +#define POWER_MODE1_CLOCK_PLL3_ENABLE > 1 > +#define POWER_MODE1_CLOCK_PLL3_DISABLE > 0 Ditto here? > +// 2D registers. C++ comments are not allowed. > +#define DE_REGISTER_OFFSET 0x100000 > +#define DE_SOURCE 0x000000 Check alignment. ...and so on. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] I read part of it all the way through. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
