Hi On Wed, Jul 30, 2008 at 12:13 AM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > In message <[EMAIL PROTECTED]>> you wrote: >> If CONFIG_SKIP_RELOCATE_UBOOT is set the flag GD_FLG_RELOC is usually never >> set, because relocation to RAM is actually never done by U-boot itself. >> However, several pieces of code check if this flag is set at some time. >> >> So, to make sure this flag is set on boards skipping relocation, this >> is added to the initialisation of U-boot at a moment where it is safe >> to do so. >> >> V2: Forgot to add 'return 0;' to reloc_init() routine. >> >> Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> >> --- >> lib_arm/board.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) > > Applied, thanks.
To me it seems like GD_FLG_RELOC is not set unless CONFIG_SKIP_RELOCATE_UBOOT is set. Other boards (mips, ppc etc) set GD_FLG_RELOC in their board_init_r function but as far as I can see this does not happen for ARM boards. Shouldn't it be set in lib_arm/board.c:start_armboot right after the gd pointer has been initialized? I just took the latest git tree and built an i.MX31 Litekit binary (with defining CONFIG_SKIP_RELOCATE_UBOOT) and GD_FLG_RELOC is not set after boot. Thanks, Magnus ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
