Guennadi Liakhovetski wrote:
>>      /* Begin command latch cycle */
>> -    this->cmd_ctrl(mtd, cmd, ctrl);
>> +    this->cmd_ctrl(mtd, cmd, NAND_CTRL_CLE | NAND_CTRL_CHANGE);
> 
> [snip]
> 
> See? you do the same! You replace short lowercase variable with long 
> uppercase macros:-) 

:-)

Yes, but in this case it's not just a name change; the old "ctrl" 
variable was stateful and thus less clear.

-Scott

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to