> Don't cast the return of malloc. ok.
> Why not just declare a static array? I tried with a static array but it doesn't give the expected result (a quick test with onenand info command returns an empty mtd name), so I used a pointer. > It'd be better to use snprintf, even if you're pretty sure it won't > overflow. I tried it too :) U-Boot doesn't have snprintf or asprintf or I missed something. Do I need to re-submit the patch only for cast ? cheers, Fathi ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
