Dear Timur Tabi, In message <[EMAIL PROTECTED]> you wrote: > > I don't know much about 8xx, but on 8xxx, all the information needed for I2C > configuration is in the board configuration files. Couldn't we just move > i2c_init earlier?
I don;t remember all the details, sorry. One problem might have been that the cases I mentioed are running from flash, i. e. before relocation, where we cannot write to variables in the data segment. Thus a "real" i2c_init later, after relocation, may still be needed. > Is there a way to test on all the 8xx boards that U-Boot supports? If not, All boards? No chance. Even testing a small fraction like 10...20 boards is a substantial amount of effort. > would it be okay to make a best-guess attempt at modifying the code to call > i2c_init() earlier for those boards that need it (e.g. call it from scc_init() > on the lwmon board), and hope someone else notices any bugs in other 8xx > boards? That would mean to add even more #ifdef'ery to more common files - I don;t think that this is a good odea. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Certainly there are things in life that money can't buy, but it's very funny - Did you ever try buying them without money? - Ogden Nash ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
