Hi Prodyut, On Thursday 21 August 2008, Prodyut Hazarika wrote: > Thanks for your comments. I did not know about the commit text conventions. > I will be more careful in future.
Good. Thanks. > > You still introduced a few too long lines in the code (I already > > commented about this). I'll clean this up with a follow up patch. > > Could you please let me know which lines were the problem. > I would like to know the problem so that it does not get repeated in > future. Sure: [EMAIL PROTECTED] linus (master)]$ ./scripts/checkpatch.pl ~/git/u-boot/u-boot-ppc4xx/patches_amcc/\[PATCH\]\ ppc4xx\:\ Optimize\ PLB4\ Arbiter\ and\ Memory\ Queue\ settings\ for\ PPC\ 440SP_SPe\,\ PPC405EX\ and\ PPC\ 460EX_GT.mbox ERROR: trailing whitespace #101: FILE: cpu/ppc4xx/44x_spd_ddr2.c:2262: +^I * Enable high bandwidth access $ WARNING: line over 80 characters #113: FILE: cpu/ppc4xx/44x_spd_ddr2.c:2274: + val = (mfdcr(SDRAM_CONF1HB) | SDRAM_CONF1HB_AAFR | SDRAM_CONF1HB_RPEN | SDRAM_CONF1HB_RFTE); ERROR: trailing whitespace #114: FILE: cpu/ppc4xx/44x_spd_ddr2.c:2275: +^Imtdcr(SDRAM_CONF1HB, val); $ WARNING: line over 80 characters #116: FILE: cpu/ppc4xx/44x_spd_ddr2.c:2277: + val = (mfdcr(SDRAM_CONF1LL) | SDRAM_CONF1LL_AAFR | SDRAM_CONF1LL_RPEN | SDRAM_CONF1LL_RFTE); ERROR: trailing whitespace #117: FILE: cpu/ppc4xx/44x_spd_ddr2.c:2278: +^Imtdcr(SDRAM_CONF1LL, val); $ Again, you can also apply the patch (email) to your repo with git-am and should see some warnings there. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot