Tsi-Chung Liew <[EMAIL PROTECTED]> wrote:
> From: TsiChung Liew <[EMAIL PROTECTED]>
>
> Add MTD SPI Flash support for M25P16, M25P20, M25P32,
> M25P40, M25P64, M25P80, M25P128.
>
> Signed-off-by: Jason McMullan <[EMAIL PROTECTED]>
> Signed-off-by: TsiChung Liew <[EMAIL PROTECTED]>
Looks good to me, except...
> +static const struct stmicro_spi_flash_params stmicro_spi_flash_table[] = {
> + {
> + .idcode1 = STM_ID_M25P16,
> + .page_size = 256,
> + .pages_per_sector = 256,
> + .nr_sectors = 32,
> + .name = "M25P16",
> + },
> + {
> + .idcode1 = STM_ID_M25P20,
> + .page_size = 256,
> + .pages_per_sector = 256,
> + .nr_sectors = 4,
> + .name = "M25P20",
> + },
> + {
> + .idcode1 = STM_ID_M25P32,
> + .page_size = 256,
> + .pages_per_sector = 256,
> + .nr_sectors = 64,
> + .name = "M25P32",
> + },
> + {
> + .idcode1 = STM_ID_M25P40,
> + .page_size = 256,
> + .pages_per_sector = 256,
> + .nr_sectors = 8,
> + .name = "M25P40",
> + },
> + {
> + .idcode1 = STM_ID_M25P64,
> + .page_size = 256,
> + .pages_per_sector = 256,
> + .nr_sectors = 128,
> + .name = "M25P64",
> + },
> + {
> + .idcode1 = STM_ID_M25P80,
> + .page_size = 256,
> + .pages_per_sector = 256,
> + .nr_sectors = 16,
> + .name = "M25P80",
> + },
> + {
> + .idcode1 = STM_ID_M25P128,
> + .page_size = 256,
> + .pages_per_sector = 1024,
> + .nr_sectors = 64,
> + .name = "M25P128",
> + },
> +};
The indentation is a bit weird here. Please use tabs only.
Who will apply this, btw?
Haavard
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
