Hi Stefan and Ben, I saw what Andy Fleming's did. This is a bit to much work for what I have time for.
I aggree, we need to take baby steps.. For now I'll change PHY-less to Fixed PHY and update some style issues. -Victor Gallardo -----Original Message----- From: Stefan Roese [mailto:[EMAIL PROTECTED] Sent: Thursday, September 04, 2008 8:34 AM To: Ben Warren Cc: u-boot@lists.denx.de; Victor Gallardo Subject: Re: [U-Boot] [PATCH 1/1 v3] ppc4xx: Add support for GPCS, SGMII and M88E1112 PHY On Thursday 04 September 2008, Ben Warren wrote: > I like the idea very much, but am not sure about the implementation. > This problem has been around for a while (just search the archives for > people wondering how to deal with a switch chip connected via rvMII or > whatever). The trickiest part of this is how to get the information > to the driver. I've always thought that the best way would be for > board code to initialize each controller through proper C code (i.e. > not CONFIG macros). But there's definitely something to be said for > doing it all through macros, since that's how Kconfig works. Please > have a look at the code that Andy Fleming recently submitted for the > TSEC driver (it's in the main branch now). He passes a > tsec_info_struct into each call of tsec_initialize(), allowing all > type of custom information to go in. In my mind, that could be > generalized to something that more than just TSEC, but let's take baby steps. Yes, this looks like a good approach. Not sure if we should go all the way or accept Victors approach for now. Moving to this parameter based initialization is a different matter that should really be done soon. > Incidentally, the term "Fixed PHY" has already been coined for what > you're calling "PHY-less". I suggest we standardize. Yes. Is there already a define available? > Anyway, I have to go to bed. Eyes are starting to close and brain's > sloowwwiing doowwn. Heh :) Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot