Dear Adam Graham,

In message <[EMAIL PROTECTED]> you wrote:
> Provide a weak defined routine to retrieve the CPU number for reference 
> boards that have multiple CPU's.  Default behavior is the existing single CPU 
> print output.  Reference boards with multiple CPU's need to provide a board 
> specific routine.  See board/amcc/arches/arches.c for an example.

Line too long.

> +int __get_cpu_num(void)
> +{
> +     return __NA_OR_UNKNOWN_CPU;
...

> --- a/include/ppc4xx.h
> +++ b/include/ppc4xx.h
> @@ -218,4 +218,7 @@ static inline void set_mcsr(u32 val)
>  
>  #endif       /* __ASSEMBLY__ */
>  
> +/* for multi-cpu support */
> +#define      __NA_OR_UNKNOWN_CPU     -1

Please don't use identifiers starting with underscores. These have  a
special meaning in C.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Der Horizont vieler Menschen ist ein Kreis mit Radius Null --
und das nennen sie ihren Standpunkt.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to