On Fri, Oct 17, 2008 at 4:11 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
>> +/* The 8544 RM says this is bit 26, but it's really bit 28 */ >> #define MPC85xx_PORDEVSR2_SEC_CFG 0x00000080 > > But 0x00000080 is bit 24; bit 28 would be 0x00000008 - or not? I just based my comment on the changelog of the previous patch, so that means that either the git changelog or the code for that patch is wrong. I guess that's a good reason not to use git changelogs as a substitute for code comments. Changelogs can't be edited. The previous patch had this: The MPC8544 RM incorrect shows the SEC_CFG bit in PORDEVSR2 as being bit 26, instead it should be bit 28. ... -#define MPC85xx_PORDEVSR2_SEC_CFG 0x00000020 +#define MPC85xx_PORDEVSR2_SEC_CFG 0x00000080 x80 is definitely bit 24. So the question for Kumar is: which is the right value for MPC85xx_PORDEVSR2_SEC_CFG: 0x80 (bit 24) or 0x08 (bit 28)? -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
