-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Jerry, thx for your comments, i will pay attention on the right patch format the next time. It is my first project I send patches to and until now, git is not my best friend.
Sorry for my poor english, it is not my native language and i dont know that this is a problem here. Georg Jerry Van Baren schrieb: > Georg Schardt wrote: >> From: schardt <[EMAIL PROTECTED]> >> >> this patch adds support for the avnet fx12 minimodul it needs the >> "ppc4xx: Generic architecture for xilinx ppc405" patch from >> Ricardo >> >> <v2> rebased to ppc4xx/master > > The above two^Wfour lines should go *below* the "---", they are > remarks WRT the patch, not really a commit comment for posterity. > Ahh, also the line "it needs the "ppc4xx: Generic architecture for > xilinx ppc405" patch from Ricardo" should go below the "---". > > Also, s/minimodul/minimodule/ unless it really *is* spelled w/o the > "e". > > While we are critiquing the English, sentences start with capital > letters and end with periods, as in "This patch adds support for > the avnet fx12 minimodule." > > WRT the subject line, the <v2> should go *inside* the [PATCH v2] so > it doesn't get included in the git repository comment. > >> Signed-off-by: schardt <[EMAIL PROTECTED]> Signed-off-by: >> Ricardo Ribalda Delgado <[EMAIL PROTECTED]> --- > > Put your remarks here. > >> MAINTAINERS | 4 + MAKEALL >> | 1 + Makefile | 18 +++++ >> board/avnet/fx12mm/.gitignore | 1 + >> board/avnet/fx12mm/Makefile | 27 +++++++ >> board/avnet/fx12mm/config.mk | 26 +++++++ >> board/avnet/fx12mm/fx12mm.c | 52 +++++++++++++ >> board/avnet/fx12mm/init.S | 32 ++++++++ >> board/avnet/fx12mm/u-boot.lds | 149 >> ++++++++++++++++++++++++++++++++++++++ >> board/avnet/fx12mm/xparameters.h | 51 +++++++++++++ >> include/configs/fx12mm.h | 72 ++++++++++++++++++ > > [snip] > > The bike shed is blue today. > > Thanks, gvb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkj/Hl0ACgkQUicxT/v10ZuYQwCdFQ4wFp4N2lyeTy01PPpEHnjd kGgAniHDR2OxkXkbljMi/EU+5vKvVK9p =n6XX -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot