Dear Stanislav Sedov,
In message <[EMAIL PROTECTED]> you wrote:
>
> Content-Type: multipart/signed; protocol="application/pgp-signature";
Please send plain text, no fancy MIME multipart stuff.
> The patch attached implements the FFS/UFS FreeBSD filesystem
> support for u-boot. Hopefully, it will be useful for
> someone.
It will, but:
- Your Signed-off-by: line is missing.
- Your patch does not apply:
-> patch -p1 --dry-run </tmp/patch
patching file Makefile
Hunk #1 FAILED at 210.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.rej
patching file common/Makefile
Hunk #1 succeeded at 88 with fuzz 1 (offset 26 lines).
patching file common/cmd_ffs.c
patching file fs/Makefile
Hunk #1 FAILED at 22.
1 out of 1 hunk FAILED -- saving rejects to file
fs/Makefile.rej
patching file fs/ffs/Makefile
patching file fs/ffs/ffs.c
patching file include/ffs.h
patching file include/ffs_dinode.h
patching file include/ffs_fs.h
- And checkpatch.pl reports a lot of (mostly minor) stylistic issues.
The ones you really have to clean up are these:
ERROR: need consistent spacing around '&' (ctx:WxO)
#1795: FILE: include/ffs_fs.h:578:
+ ((fsb) &~ ((fs)->fs_frag - 1))
^
ERROR: space prohibited after that '~' (ctx:OxW)
#1795: FILE: include/ffs_fs.h:578:
+ ((fsb) &~ ((fs)->fs_frag - 1))
Please clean up and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
I'd rather be led to hell than managed to heaven.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
