On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> introduce two new weak functions board_bdinfo and soc_bdinfo to allow board 
> and
> soc to print more information

there seems to be things that all arches print ... like memory and
flash information.  perhaps that should be left in the common
bdinfo().

> +void board_bdinfo(cmd_tbl_t *, int, int, char **) __attribute((weak));
> +void soc_bdinfo(cmd_tbl_t *, int, int, char **) __attribute((weak));

__attribute__

> +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +       if(soc_bdinfo)
> +       if(board_bdinfo)

you've got random whitespace damage all over this patch ...

thanks
-mike
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to