On Tuesday 18 November 2008, Shinya Kuribayashi wrote:
> >> +++ b/lib_mips/board.c
> >> @@ -70,6 +70,15 @@ static ulong mem_malloc_brk;
> >> */
> >> unsigned long mips_io_port_base = -1;
> >>
> >> +int __board_early_init_f(void)
> >> +{
> >> + /*
> >> + * Nothing to do in this dummy implementation
> >> + */
> >> + return 0;
> >> +}
> >
> > why not remove this and create a generic dummy function
> > to reduce to code size impact
>
> +1. Such dummy function could be shared among all architectures.
OK, makes perfect sense. We would need different dummy functions for each
different parameter though, such as:
void dummy_void_void(void);
int dummy_int_void(void);
int dummy_int_int(int);
int dummy_int_pint(* int);
...
And where should those functions be placed? We could create a new file
probably in lib_generic for this. I suggest we postpone this consolidation
until after the next release though.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED]
=====================================================================
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
