> From: Stefan Roese [mailto:[EMAIL PROTECTED] > On Monday 01 December 2008, Scott Wood wrote: > > Please factor this out into arch code, and make it > shareable with other > > NAND code (such as nand_boot.c). > > Yes, please. > > > > + /* > > > + * We need clean dcache and invalidate > > > + * to sync between icache and dcache > > > + * before jump to RAM. make sure all of > > > + * NAND data write to memory. > > > > "Clean d-cache and invalidate i-cache, to make sure that > > no stale data is executed." > > And the function name is not perfectly fitting for my taste. > Why not extract 2 > functions, flush_dcache_range() and > invalidate_icache_range(). This reminds > me that some architectures/platforms already have those > functions defined > (PPC4xx at least does). But the 2nd parameter is not size but > end ("stolen" > from the Linux kernel). Perhaps it makes sense to use these > functions here as > well.
No architecutres/plaforms, I expect we can put all of cache-specificed functions into lib_ppc/cache.S or lib_ppc/cache.c. How about this? _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
