On Wednesday 10 December 2008 14:57:27 Wolfgang Denk wrote: > In message ... you wrote: > > diff --git a/tools/easylogo/easylogo.c b/tools/easylogo/easylogo.c > > index 00a1e4e..c7e146f 100644 > > --- a/tools/easylogo/easylogo.c > > +++ b/tools/easylogo/easylogo.c > > @@ -2,16 +2,20 @@ > > ** Easylogo TGA->header converter > > ** ============================== > > ** (C) 2000 by Paolo Scaffardi ([EMAIL PROTECTED]) > > +** (C) 2007-2008 Mike Frysinger <[EMAIL PROTECTED]> > > ** AIRVENT SAM s.p.a - RIMINI(ITALY) > > This is a bad place to add your copyright - splitting Paolo's entry.
oops, i didnt notice
> > + if (fread (compressed, st.st_size, 1, gz) != 1) {
> > + perror ("\nerror: reading gzip data failed");
> > + return -1;
> > + }
>
> All the returns above leak the gzfilename and gzcmd memory. Not that
> it really matters, but it's not clean.
ok
> Also, please omit the "\n" at the begin of the perror strings.
easylogo's output is byte by byte, so no \n means the error message and the
normal output run together
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
