Dear Stefan Althoefer,

In message <49384710.dwdg58iab1mkoo9u%[email protected]> you wrote:
> [PATCH] IXP425: make cmd_go handle caches correctly
> 
> This patch adds icache_invalidate() and dcache_flush() to
> cpu/ixp/cpu.c.
> 
> Also it adds do_go_exec() which is called from do_go().
> This private implementation performs cache handling
> before jumping into the code.
> 
> Without this cache handling, you will jump into stale
> code if you download a program several times.

Coding style: please use TABs for indentation.

> The patch is against "latest" u-boot git-repository
> 
> Please (still) be patient if style of submission or patches are
> offending.

And move such comments below th e"---" line, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to