On Dec 15, 2008, at 6:46 PM, Wolfgang Denk wrote: > Dear Kumar, > > In message <8FDAD51E-151A-43C8- > [email protected]> you wrote: >> >> On Dec 15, 2008, at 3:07 PM, Wolfgang Denk wrote: >> >>> Dear Kumar Gala, >>> >>> In message <1229210430-4522-2-git-send-email- >>> [email protected]> you wrote: >>>> Add a library that helps in translating between virtual and >>>> physical >>>> addresses. This library can be useful as a simple means to >>>> implement >>>> map_physmem() and virt_to_phys() for platforms that need >>>> functionality >>>> beyond the simple 1:1 mapping. >>>> >>>> Signed-off-by: Kumar Gala <[email protected]> >>>> --- >>>> * Folded in Becky's phys_size_t changes >>>> >>>> include/addr_map.h | 29 +++++++++++++++++ >>>> lib_generic/Makefile | 1 + >>>> lib_generic/addr_map.c | 81 ++++++++++++++++++++++++++++++++++++ >>>> ++ >>>> ++++++++++ >>>> 3 files changed, 111 insertions(+), 0 deletions(-) >>>> create mode 100644 include/addr_map.h >>>> create mode 100644 lib_generic/addr_map.c >>> >>> Applied, thanks. > > I'm afraid your patch causes problems on the Katmai board: > > Configuring for katmai board... > In file included from 44x_spd_ddr2.c:46: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size
There was a patch in my series that fixed this: [PATCH 01/11] powerpc: fix io.h build warning with CONFIG_PHYS_64BIT That really needs to become part of Kumar's series since katmai has 64bit enabled. -Becky > > In file included from display_options.c:27: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from 4xx_pcie.c:32: > /home/wd/git/u-boot/work/include/asm-ppc/io.h: In function > 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm-ppc/io.h:303: warning: cast > from pointer to integer of different size > In file included from bat_rw.c:28: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from commproc.c:29: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from denali_data_eye.c:38: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from denali_spd_ddr2.c:45: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from ecc.c:44: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from i2c.c:33: > /home/wd/git/u-boot/work/include/asm-ppc/io.h: In function > 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm-ppc/io.h:303: warning: cast > from pointer to integer of different size > In file included from iop480_uart.c:27: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from tlb.c:30: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from 4xx_uart.c:47: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from gpio.c:26: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from miiphy.c:39: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from systemace.c:45: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from cfi_flash.c:39: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from eepro100.c:28: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from pci.c:35: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from 4xx_enet.c:84: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from pci_indirect.c:17: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from cmd_pcmcia.c:60: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from cmd_pci.c:35: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from memsize.c:30: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > In file included from katmai.c:32: > /home/wd/git/u-boot/work/include/asm/io.h: In function 'virt_to_phys': > /home/wd/git/u-boot/work/include/asm/io.h:303: warning: cast from > pointer to integer of different size > text data bss dec hex filename > 268208 15484 127736 411428 64724 ./u-boot > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] > "In matrimony, to hesitate is sometimes to be saved." - Butler > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot

