Hi Matthias, On Friday 02 January 2009, Matthias Fuchs wrote: > On ppc4xx platforms __ft_board_setup updates clock-frequency > properties of all ns16550 compatible UARTs. This is not a good > idea when those UARTs are external discrete UARTs that are > not clocked by some internal clocks. So any external clock value > in the DTB is overwritten and those UARTs will not be setup correctly > by the Linux kernel. > > This patch uses the approach from fdt_fixup_ethernet(). Only UART nodes > that have a serial* alias are updated.
Wouldn't it be "better" to check if an external UART clock is configured via CONFIG_SYS_EXT_SERIAL_CLOCK and just use it instead of the calculated internal clock value in this case? BTW: This patch version is not ppc4xx specific as it touches the common fdt_support.c. So you would need to split this patch if we decide to go your way. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
