On 11:46 Thu 22 Jan , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090122082908.gc15...@game.jcrosoft.org> you wrote: > > > > > > - /* arch number MACH_TYPE_ARMADILLO - not official*/ > > > > - gd->bd->bi_arch_number = 83; > > > > + gd->bd->bi_arch_number = MACH_TYPE_ARMADILLO; > ... > > > You actually CHANGE the arch_number here; you need the board > > > maintainer's ACK for such a patch. > > the ARMADILLO was changed in the current kernel it's not any more 83 but 615 > > I am aware of this. But anybody using some Linux kernel runnin on this board > will have a nasty surprise when hisl old kernels don;t boot any more > with recent versions of U-Boot. > > This is why I request that you ask for an ACK from the board > maintainer - he needs to be at least aware of such a change. > > > > Note that there are other places where this is used - these must be > > > changed, too - for example: > > > > > > "board/lpc2292sodimm/lpc2292sodimm.c": > > > > > > 42 /* arch number MACH_TYPE_ARMADILLO - not official*/ > > > 43 gd->bd->bi_arch_number = 83; > > I've not find it in the official list so I've let as 83 (non registered > > board) > > You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but > not in others? This will cause inconsistent behaviour. > > You must not do that. Either leave ALL of these as they are, or fix > ALL of them in the SAME way. the other board are not a ARMODILLO correct if I wrong
Best Regards, J. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
