On Fri, Jan 23, 2009 at 4:37 PM, Wolfgang Denk <w...@denx.de> wrote:
> Dear Gunnar Rangoy,
>
> In message 
> <7d98d3ebed68dfca910943a360d0b8aaa28d9c17.1232710611.git.gun...@rangoy.com> 
> you wrote:
>> This patch adds support for the ATEVK1100 evaluation kit, which contains
>> an AT32UC3A0512ES chip.
> ...
>
> ...
>> --- /dev/null
>> +++ b/board/atmel/atevk1100/atevk1100.c
> ...
>> +     /*
>> +     .ncs_wr_pulse   = 1,
>> +     .ncs_rd_pulse   = 1,
>> +     .nwe_pulse      = 1,
>> +     .nrd_pulse      = 1,
>> +     .nwe_cycle      = 2,
>> +     .nrd_cycle      = 2,
>> +     */
>
> All this is dead code. Please remove.

Will do that.

> ...
>> +/*
>> + * Command line configuration.
>> + */
>> +#include <config_cmd_default.h>
>> +
>> +#define CONFIG_CMD_ASKENV
>> +#define CONFIG_CMD_DHCP
>> +
>> +#undef CONFIG_CMD_AUTOSCRIPT
>
> Is there a specific reason for not allowing to use shell scripts?
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> I'm a programmer: I don't buy software, I write it.
>                                                  -- Tom Christiansen
>

No, not really. We did this because this was done in other AVR32 boards
we used as references.


-- 
Gunnar Rangøy,
99360699
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to