Dear Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 06:53 Mon 02 Feb , Dirk Behme wrote: >> * Make Overo GPIO114 an input for touchscreen PENDOWN >> * Make Overo GPIO144-147 readable >> * Make Overo EHCI pinmux match beagle rev c setup >> * Adjust pinmux for SMSC911X network chip support >> * Remove unnecessary GPIO setup >> * Fix merge error in Makefile > maybe we could split it a few more
Yes, we could. But no, we don't want to split ~20 changed lines into even smaller parts to a) avoid spamming the list b) avoid polluting the git history > because it's not so easy to folow which modification fix what? Well, looking at the patch, I would say that it is obvious that * Make Overo GPIO114 an input for touchscreen PENDOWN refers to the change which is commented with /*GPIO_114*/\ and * Make Overo GPIO144-147 readable refers to the change with the comments GPIO_144, GPIO_145, GPIO_146 and GPIO_147 and * Make Overo EHCI pinmux match beagle rev c setup refers to the change with USB comment and * Adjust pinmux for SMSC911X network chip support refers to the change with SMSC911X comment and * Remove unnecessary GPIO setup refers to the changes which remove GPIO stuff commented e.g. with "/* Set GPIOs */" and * Fix merge error in Makefile refers to the change in Makefile +++ u-boot-main/board/omap3/overo/Makefile Dirk _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
