On Fri, 6 Feb 2009 23:18:20 +0100 Jean-Christophe PLAGNIOL-VILLARD <[email protected]> wrote: > On 22:54 Sun 04 Jan , Jürgen Schöw wrote: > > cpu/arm926ejs/pnx8181/Makefile | 45 +++ > > cpu/arm926ejs/pnx8181/timer.c | 141 ++++++++ > > drivers/i2c/Makefile | 1 + > > drivers/i2c/pnx8181_i2c.c | 304 +++++++++++++++++ > > > > diff --git a/cpu/arm926ejs/pnx8181/timer.c > > b/cpu/arm926ejs/pnx8181/timer.c new file mode 100644 > > index 0000000..585aede > > --- /dev/null > > +++ b/cpu/arm926ejs/pnx8181/timer.c > > +#define PNX8181_SCTU_TIMxRR 0x04 > > +#define PNX8181_SCTU_TIMxWR 0x08 > > +#define PNX8181_SCTU_TIMxC0 0x0c > > +#define PNX8181_SCTU_TIMxC1 0x10 > > +#define PNX8181_SCTU_TIMxC2 0x14 > > +#define PNX8181_SCTU_TIMxC3 0x18 > > +#define PNX8181_SCTU_TIMxSR 0x1c > > +#define PNX8181_SCTU_TIMxPR 0x20 > please moce this to a header
Yes, done. > > diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile > > index 6079c05..ef457a5 100644 > > --- a/drivers/i2c/Makefile > > +++ b/drivers/i2c/Makefile > > @@ -31,6 +31,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += > > omap1510_i2c.o COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o > > COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o > > COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.o > > +COBJS-$(CONFIG_PNX8181_I2C) += pnx8181_i2c.o > please keep list sorted Yes, will change this. > > diff --git a/drivers/i2c/pnx8181_i2c.c b/drivers/i2c/pnx8181_i2c.c > > new file mode 100644 > > index 0000000..75a76a4 > > --- /dev/null > > +++ b/drivers/i2c/pnx8181_i2c.c > > @@ -0,0 +1,304 @@ > > +#define ARM_VPB1_BASE_ADDR 0xC2000000 > > +#define ARM_VPB3_BASE_ADDR 0xC2200000 > > +#define ARM_VPB_SIZE_SHIFT 12 > please move define to a header > > + OK, done. > > +#define I2C_ADR_REG (void *)(I2C_BASE + I2C_ADR_OFFSET) > ^^^^^^^^^^^^^ > whitespace please fix > > +#define I2C_SADDR_FIELD 0xFFFFFF80 > ^^^^^^^^^ > whitespace please fix > and other in the code please fix Sorry, I searched for all whitespace errors, but it seemed I missed those. Thanks for mentioning. Being on FOSDEM, I will try to send the next patchset as soon as possible. BTW: Thanks for reviewing! Regards Jürgen Schöw
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
