Hello ksi, [email protected] wrote: > This is the first attempt of multi-adapter multi-bus I2C subsystem rework > for U-Boot. > > This batch deals with fsl_i2c and soft_i2c drivers. All (hopefully :) > > relevant parts are changed -- config files for all boards affected, lib_xxx, > board/* etc. > > Please see illustrative section of MPC8548CDS.h config file for an example > for 2 soft_i2c, 2 fsl_i2c, 1 sm502_i2c adapters and 7 busses some of them > connected via I2C multiplexers. > > All comments, suggestions etc. are very welcome. >
Common comments: - you mixed Coding Style cleanup with functional changes in one patch, please don't do this - I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think? > I'm going to move _ALL_ I2C drivers to drivers/i2c and rework all the > configs and other relevant stuff in next batches. Then I will do another run > to completely remove CONFIG_NEW_I2C and get rid of CONFIG_HARD_I2C. > > The patches are in next 8 emails. > It looks like to me, that this "8 patches" is only one big patch, that you just splitted in 8 EMails, don't do this. Please try to make real n patches from this big one (for example, the changes in fsl_i2c.c in one extra patch). > Signed-off-by: Sergey Kubushyn <[email protected]> > Why here a Signed-off-by? For what? bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
