Hello Mike,
Mike Frysinger wrote:
> On Tuesday 10 February 2009 03:38:52 Heiko Schocher wrote:
>> +int NetInitLoop(proto_t protocol)
>
> and some comments not really specific to your code ...
>
>> + switch (protocol) {
>> +#if defined(CONFIG_CMD_NFS)
>> + case NFS:
>> +#endif
>> + case NETCONS:
>> + case TFTP:
>> + NetServerIP = getenv_IPaddr ("serverip");
>> + break;
>> +#if defined(CONFIG_CMD_PING)
>> + case PING:
>> + /* nothing */
>> + break;
>> +#endif
>> +#if defined(CONFIG_CMD_SNTP)
>> + case SNTP:
>> + /* nothing */
>> + break;
>> +#endif
>> + default:
>> + break;
>> + }
>
> am i missing something, or are the PING/SNTP parts here completely useless
Yes, seems so, but I am not a net expert ... but I think it is not needed, so
I fix this too when I am fixing the other issues you mentioned.
>> + case BOOTP:
>> + case RARP:
>> + /*
>> + * initialize our IP addr to 0 in order to accept ANY
>> + * IP addr assigned to us by the BOOTP / RARP server
>> + */
>> + NetOurIP = 0;
>> + NetServerIP = getenv_IPaddr ("serverip");
>> + NetOurVLAN = getenv_VLAN("vlan"); /* VLANs must be read */
>> + NetOurNativeVLAN = getenv_VLAN("nvlan");
>> + case CDP:
>> + NetOurVLAN = getenv_VLAN("vlan"); /* VLANs must be read */
>> + NetOurNativeVLAN = getenv_VLAN("nvlan");
>> + break;
>
> looks to me like BOOTP/RARP are pointlessly reading/setting NetOurVLAN and
> NetOurNativeVLAN twice ...
Yep, I fix this also.
thanks
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
