Hi Marek,
On Nov 28, 2012, at 4:45 AM, Marek Vasut wrote:
> Dear Pantelis Antoniou,
>
>> USB initialization shouldn't happen for all the boards.
>>
>> Signed-off-by: Pantelis Antoniou <pa...@antoniou-consulting.com>
>> ---
>> common/cmd_dfu.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
>> index 01d6b3a..327c738 100644
>> --- a/common/cmd_dfu.c
>> +++ b/common/cmd_dfu.c
>> @@ -55,7 +55,10 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc,
>> char * const argv[]) goto done;
>> }
>>
>> +#ifdef CONFIG_TRATS
>> board_usb_init();
>> +#endif
>> +
>
> It's common code:
>
> 1) Why is it called "board_usb_init()" ? Does this have anything to do with
> usb
> host?
>
No idea. It makes no sense to me, but it was there from the original DFU poster.
I don't have a TRATS board to test it anyway, but I didn't want to affect it.
> 2) Make it __weak, then if it's undefined for your board, something default
> will
> be called.
>
I see no reason why it should even exist. Perhaps we should ask the original
poster.
>> g_dnl_register(s);
>> while (1) {
>> if (ctrlc())
>
> Best regards,
> Marek Vasut
Regards
-- Pantelis
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
