On 11/28/2012 2:38 AM, Wolfgang Denk wrote:
Dear Troy Kisky,
In message <[email protected]>
you wrote:
Need to move accesses to the static variables to
a function where struct data_src is used.
Could you please elucidate why exactly this is _needed_?
My goal was to reduce the number of static variables, but strictly speaking
it has little benefit other than giving me a warm fuzzy feeling.
I'm not that only one that dislikes static though.
+ /* Be able to detect if the cfg file has no BOOT_FROM tag */
+ g_flash_offset = FLASH_OFFSET_UNDEFINED;
+ memset(&ds, 0, sizeof(struct data_src));
Is this initialization really needed?
Best regards,
Wolfgang Denk
ds is on the stack, and even if not needed now, I like to avoid future
random bugs.
Troy
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
