On 12/13/2012 1:54 AM, Wolfgang Denk wrote:
Dear Vipin Kumar,

In 
message<dba14c4ffef38a108f75342968bcd9ce2b75c4c7.1355303894.git.vipin.ku...@st.com>
  you wrote:
imls does not list the images in NAND devices. This patch implements this
support for legacy type images.
...
-static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+static void do_imls_flash(void)

Why is this void?  Should we not return error codes? Or at least be
able to?


Yes, I agree. I would change this

+static void do_imls_nand(void)

Ditto.


Best regards,

Wolfgang Denk


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to