Hi Tom, On Wed, Dec 19, 2012 at 12:43 PM, Tom Rini <[email protected]> wrote: > On Fri, Sep 28, 2012 at 02:28:00PM -0000, Simon Glass wrote: > >> From: James Miller <[email protected]> >> >> Output a progress update only at most 10 times per second, to avoid >> saturating (and waiting on) the console. Make the summary line >> to fit on a single line. Make sure that cursor sits at the end of >> each update line instead of the beginning. >> >> Sample output: >> >> SF: Detected W25Q32 with page size 4 KiB, total 4 MiB >> Update SPI >> 1331200 bytes written, 2863104 bytes skipped in 21.912s, speed 199728 B/s >> >> time: 21.919 seconds, 21919 ticks >> Skipping verify >> >> Signed-off-by: Simon Glass <[email protected]> >> Signed-off-by: James Miller <[email protected]> >> Signed-off-by: Taylor Hutt <[email protected]> > > With ELDK 4.2: > cmd_sf.c:80: warning: type qualifiers ignored on function return type
Interesting... > > Unless I'm missing something, this is the right fix: > -static const ulong bytes_per_second(unsigned int len, ulong start_ms) > +static ulong bytes_per_second(unsigned int len, ulong start_ms) > > Because no, we aren't returning a const. If that sounds right I'll fix > inline and add my Signed-off-by. Yes that looks right, thanks for doing that. Did Mike get in touch re these? Regards, Simon > > -- > Tom _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
