Hello Wolfgang, Wolfgang Denk wrote: > In message <[email protected]> you wrote: >> This patch adds support for the kmsupx4 board from Keymile, >> based on a Freescale MPC852T CPU > ... >> --- a/cpu/mpc8xx/start.S >> +++ b/cpu/mpc8xx/start.S >> @@ -142,7 +142,8 @@ boot_warm: >> lis r3, idc_disa...@h /* Disable data cache */ >> mtspr DC_CST, r3 >> >> -#if !(defined(CONFIG_IP860) || defined(CONFIG_PCU_E) || defined >> (CONFIG_FLAGADM)) >> +#if !(defined(CONFIG_IP860) || defined(CONFIG_PCU_E) || \ >> + defined (CONFIG_FLAGADM) || defined(CONFIG_KMSUPX4)) >> /* On IP860 and PCU E, >> * we cannot enable IC yet >> */ > > Why exactly is this necessary? > > I would like to avoid new #ifdef's in common code in general, but > here this should most likely be not needed either (IP860 and PCU E > had very special hardware issues; I don't know about FLAGADM) - are > you absolutely sure you need that?
Hmm.. when I enable the IC here the CPU is dead ... but you are right, there should be no such special thing for this port ... I try to find out more. >> diff --git a/drivers/i2c/soft_i2c.c b/drivers/i2c/soft_i2c.c >> index da6cec1..f273c67 100644 >> --- a/drivers/i2c/soft_i2c.c >> +++ b/drivers/i2c/soft_i2c.c >> @@ -43,6 +43,9 @@ >> #ifdef CONFIG_MPC866 /* only valid for MPC866 */ >> #include <asm/io.h> >> #endif >> +#ifdef CONFIG_MPC852T /* only valid for MPC852T */ >> +#include <asm/io.h> >> +#endif > > Please change into > > #if defined(CONFIG_MPC852T) || defined(CONFIG_MPC866) OK thanks Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
