Dear Angelo Dureghello,
In message <[email protected]> you wrote:
> Add support for Sysam AMCORE mcf5307 (coldfire) based board.
>
> Signed-off-by: Angelo Dureghello <[email protected]>
> Cc: Jason Jin <[email protected]>
...
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 28c052d..1d27cb7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1137,6 +1137,10 @@ Wolfgang Wegner <[email protected]>
>
> astro_mcf5373l MCF5373L
>
> +Angelo Dureghello <[email protected]>
> +
> + amcore mcf5307
Please keep the list sorted...
> +
> + for (p = pstart; p < pend; p++) {
> + if (*p != 0x55555555) {
> + printf("SDRAM test fails at: %08x\n", (uint) p);
> + return 1;
> + }
Incorrect indentation.
> +/*
> + * BOOTP options
> + */
> +#undef CONFIG_BOOTP_BOOTFILESIZE
> +#undef CONFIG_BOOTP_BOOTPATH
> +#undef CONFIG_BOOTP_GATEWAY
> +#undef CONFIG_BOOTP_HOSTNAME
Please don't undef what is not defined anyway. Please fix globally.
> +#define CONFIG_SYS_SDRAM_BASE 0x00000000
> +#define CONFIG_SYS_SDRAM_SIZE 16 /* in MB */
NAK. CONFIG_SYS_SDRAM_SIZE is always and everywhere in bytes...
> +/* reserve 128-4KB */
> +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400)
> +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024)
Are you sure this is sufficient?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
