-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/30/2013 03:10 AM, Kim Bøndergaard Poulsen wrote: > Hi Tom > > >> -----Original Message----- From: Tom Rini [mailto:tr...@ti.com] >> Sent: 29. januar 2013 21:32 To: Kim Bøndergaard Poulsen Cc: >> u-boot@lists.denx.de; vap...@gentoo.org; manjunath.ha...@ti.com >> Subject: Re: [PATCH 1/2] Davinci: Make MAC address offset in >> EEPROM configurable, CONFIG_MAC_EEPROM_ADDR >> > On 01/29/2013 02:28 AM, Kim Bndergaard wrote: >>>> --- arch/arm/cpu/arm926ejs/davinci/misc.c | 5 ++++- 1 file >>>> changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/cpu/arm926ejs/davinci/misc.c >>>> b/arch/arm/cpu/arm926ejs/davinci/misc.c index >>>> c310c69..d0389a4 100644 --- >>>> a/arch/arm/cpu/arm926ejs/davinci/misc.c +++ >>>> b/arch/arm/cpu/arm926ejs/davinci/misc.c @@ -55,11 +55,14 @@ >>>> void dram_init_banksize(void) * Read ethernet MAC address >>>> from EEPROM for DVEVM compatible boards. * Returns 1 if >>>> found, 0 otherwise. */ +#ifndef CONFIG_MAC_EEPROM_ADDR >>>> +#define > CONFIG_MAC_EEPROM_ADDR >>>> 0x7F00 +#endif int dvevm_read_mac_address(uint8_t *buf) { >>>> #ifdef CONFIG_SYS_I2C_EEPROM_ADDR /* Read MAC address. */ - >>>> if (i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, 0x7F00, + if >>>> (i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, > CONFIG_MAC_EEPROM_ADDR, >>>> CONFIG_SYS_I2C_EEPROM_ADDR_LEN, (uint8_t *) &buf[0], 6)) >>>> goto i2cerr; > > Lets use CONFIG_SYS_I2C_EEPROM_MAC_OFFSET and just set it in all > of the davinci configs (yes, that's touching more files). Thanks! > > >> So what you suggest is to add a #define >> CONFIG_SYS_I2C_EEPROM_MAC_OFFSET 0x7F00 > >> in all DAVINCI related include/configs/*.h ? > >> Also I assume you want me to remove the #ifdef >> CONFIG_SYS_I2C_EEPROM_MAC_OFFSET in misc.c? > >> My only problem is that I don't know if it makes sense to define >> it for all boards > >> grep -l DAVINCI * in include/configs gives me the following >> files: calimain.h cam_enc_4xx.h da830evm.h da850evm.h >> davinci_dm355evm.h davinci_dm355leopard.h davinci_dm365evm.h >> davinci_dm6467evm.h davinci_dvevm.h davinci_schmoogie.h >> davinci_sffsdr.h davinci_sonata.h ea20.h enbw_cmc.h hawkboard.h >> tnetv107x_evm.h > >> Anyone who knows if they all have I2C eeproms
The subset of these with CONFIG_SYS_I2C_EEPROM set to start with, should as they have been reading there already. Cc'ing the various board maintainers with the patch would be good. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRCu/WAAoJENk4IS6UOR1WKBcP/3bE685l64rhKRGhsVp7zdsT 3XsD4oKMqIeFiHwiSiiS5PXuRibgt3h3aLgbbJnrhMGKBrXsDkEvb9Mjg3f/2yqg duuWIiER6utP2WW16PzjwR5Y/RNjjttzBHfDKsZCOtoZqA8v2+MmnMNrcBZmGI48 foimzTD2VikxO63UElzX3vB83JyFkBaicNfk06vjE73wU2dRR1dnPi5+ufbyMp8r ra9BI5++xVQHBmeZiGngRkO2tESll+L6L9HiTp3NNcNU3TWvV0675lwTnmXXHYy5 yoQHCI4wXQteBixPybp/903p3BhFbw8jRnAok0icSP2chcp8Dvjt8z8n29/JCxYZ 1ZOJdfbrPQXg68Un9+AQnXIoP1wby0ldkVnUfySVNL+ZzKXNA249idx8aY4s1V/K 8jBwP9xMhEaCVirP/DnLV3MetXNKy8hiE9pXqMUhuRn1xe3GwUGV4VUC0EgHJNfx iK8Ne/p68Oeol8WHrWqG3gG9UMZgSzUqWKMSeSIILclLoo8DXLNRM2HM630rfgdA E1MMzpBHPp4XB7RArlWXmibbh9A+ZLFraUZzCp75+OF3Ox0Tdn+vPKyMkf5qXV8w WMZSKZBQbFI2xAYzi6YlcqBP2jC/6e2zOwFXvehQErRI51H5gLMsv0MoPnPx54t4 sUbq0r0V0EdaH2LCS2iM =zDPr -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
