On Feb 8, 2013, at 6:34 PM, Scott Wood <[email protected]> wrote:
> On 02/08/2013 10:44:30 AM, Harvey Chapman wrote: > This should go inside the "not raw" path of the previous "if" statement. > Please use tabs to indent. > We already have "nand" in this context. > We already have "size" -- and you don't even seem to use it. > Offsets do not fit in "int". Use loff_t. > Braces around multi-line "if" bodies (even if a single statement). > Please leave a blank line after the variable declaration block. > Maybe move this to its own function (having both "offset" and "off" is > unpleasant, plus this function is way too big already). > We need this adjustment to be made to erase.part/chip as well. Thanks for the feedback. This was just a proof of concept. I'll make the changes and submit the patch more formally. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
