Stephen/Rhyland, On Tue, Feb 26, 2013 at 4:10 PM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 02/26/2013 01:46 PM, Tom Warren wrote: >> Took these values directly from the kernel dts files. > >> diff --git a/arch/arm/dts/tegra30.dtsi b/arch/arm/dts/tegra30.dtsi > >> + sdhci@78000000 { >> + compatible = "nvidia,tegra30-sdhci", "nvidia,tegra20-sdhci"; > > Looking at this more, I /think/ this should only include the Tegra30 > compatible value, since there are new quirks that are required to be > enabled on Tegra30 relative to Tegra20 or the HW won't work. The kernel > DT file is no doubt buggy here. Looking at the SDMMC reg space in the T20 and T30 TRMs, I don't see anything major that would make the MMC driver not work on T30 as is (in fact, I know it works just fine w/o modification). Looking at the sdhci-tegra.c driver source, the only quirk difference is DATA_TIMEOUT_USES_SDCLK. The U-Boot Tegra MMC driver doesn't reference the caps Timeout Clock Frequency bits, so this quirk/difference doesn't matter.
> > Cc'ing Rhyland and Pavan to confirm this. (Note: this is > Tegra30-vs-Tegra20, not Tegra114-vs-Tegra30 that we just discussed > downstream). Let's see what Rhyland/Pavan have to say before I change this. Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot