-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/01/2013 01:21 PM, Simon Glass wrote: > Hi Tom, > > On Fri, Mar 1, 2013 at 9:37 AM, Tom Rini <[email protected]> wrote: >> On Wed, Dec 26, 2012 at 11:53:34AM -0800, Simon Glass wrote: >>> This implementation uses opendir()/readdir() to access the >>> directory information and then puts it in a linked list for the >>> caller's use. >>> >>> Signed-off-by: Simon Glass <[email protected]> --- >>> arch/sandbox/cpu/os.c | 101 >>> +++++++++++++++++++++++++++++++++++++++++++++++++ include/os.h >>> | 48 +++++++++++++++++++++++ 2 files changed, 149 >>> insertions(+), 0 deletions(-) >> >> Since the code looks fine, >> >> Reviewed-by: Tom Rini <[email protected]> >> >> But a question. Do you really want this in cpu/os.c rather than >> some new file for filesystem stuff (since this is the arch side >> of sandboxfs) ? I can see you saying it should stay here since >> it's all OS interaction related stuff. > > Thanks for reviewing. The practical reason why everything is in > os.c is that this file is the interface between files which > include common.h and files which include system headers. But > logically speaking, I have tended to make os.c hold anything that > interfaces with or calls a Linux API function. > > We could certainly create something like os_filedir,c or similar > if os.c is getting a bit large. But it would still need to include > system headers. I don't think we want anything like this in in > drivers/ at present.
I agree with not putting this into drivers/ as it's sandbox-side stuff. If os.c isn't yet unwieldy to you, OK, we can go as-is. But I'll ask next time you add another big hunk to os.c I'll ask if it's unwieldy yet. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRMPLmAAoJENk4IS6UOR1W+1YP/Rveu5b/OoEPqTqo6akhTiZa chVnl0td2tFYW6SQmLfCn8qPLBjsprsxlUzAywkvBzn8HJ33wPtKx00vCj04m9Fw ELbFuGpEkLEkHL6UEF2j9PGtZKudqybl7m0RRWIZfVA3ku4rPvav0w59WFzhNKF7 5EqzMyfvVX9XlnkVJ6H75H/JkNFxF3DaJ9jYs7zeOxmlyhgPby4df8GQEENpOvRs co2DvlbcuT3pHXAW7jqUYMb3wGphvCKlb2NE8fOjPszCm9F5En/M3i01lKFVRPZ1 MSLszZaUmMm6K4UjLVdnAAl8lPmP7SdwpsH0EhmehsVlh7jshbjhbEgAcN4tr2+V nUP/yW8gJl3oJ0JL04HV0ggYY7U71WnTRC+AMJcFdfen/4btfqGkJbERp5fiO6La qO8kx+mhl4hycMB+2pAhux6b4wK+vPXuyK7QbnliKA715S9FK3huf/u/QiPntKMA 6kE23ROuZMzvpnRu39brPCSAXLjDgyxWR+ofT/BuKPyrcXvOFjTa+IyI3EcFPKFX 0CdaGU6b/cxBVOHkBBeRLq0a5I2NNjV3dEXW78B9HmRNSpeDpCiZrNKDOe5ov1XH MVqthVBxQWgvoSZrQ+t4ff8dnP2fjNJfaUn15+EzmM8YZDPownNlaLaiSMuKL3dR XmF60m4s5kHSYpLOWa9l =jsTJ -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
