Hi Tom,
Thanks.
On 3/5/2013 10:20, Tom Rini wrote:
On Tue, Mar 05, 2013 at 10:03:57AM +0800, Bo Shen wrote:
Hi Tom,
On 3/4/2013 23:14, Tom Rini wrote:
On Thu, Feb 28, 2013 at 03:00:47PM +0800, Bo Shen wrote:
[snip]
@@ -0,0 +1,268 @@
+/*
+ * Configuation settings for the SAMA5D3xEK board.
[snip]
+#undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
+
+#undef CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
+#undef CONFIG_SETUP_MEMORY_TAGS
+#undef CONFIG_INITRD_TAG
Just leave these, and the other #undef's out.
You mean I need not to #undef these, because these are not defined,
am I right?
Correct.
OK, I will remove it next version.
+/*
+ * Command line configuration.
+ */
+#include <config_cmd_default.h>
+#undef CONFIG_CMD_FPGA
+#undef CONFIG_CMD_IMI
+#undef CONFIG_CMD_IMLS
+#undef CONFIG_CMD_AUTOSCRIPT
+#undef CONFIG_CMD_LOADS
These are fine to leave in 'tho.
These are no useful for us.
I will consider remove unneeded #undef
Right.
Ditto.
And please check things with checkpatch.pl, I
thought I saw a '#define<tab>FOO' in there. Thanks!
I have checked this patch with checkpatch.pl, and get no errors and
no warnings.
OK, thanks.
Best Regards,
Bo Shen
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
