On Sat, Mar 9, 2013 at 3:30 PM, Simon Glass <[email protected]> wrote: > Hi Otavio, > > On Sat, Mar 9, 2013 at 4:31 AM, Otavio Salvador <[email protected]> > wrote: >> >> On Fri, Mar 8, 2013 at 8:45 PM, Simon Glass <[email protected]> wrote: >> > This enables generic board support so that ARM boards can define >> > CONFIG_SYS_GENERIC_BOARD. >> > >> > Signed-off-by: Simon Glass <[email protected]> >> > --- >> > Changes in v8: >> > - Define __HAVE_ARCH_GENERIC_BOARD in ARM's config.mk >> > >> > Changes in v7: None >> > Changes in v6: None >> > Changes in v5: None >> > Changes in v4: None >> > Changes in v3: None >> > Changes in v2: None >> > >> > arch/arm/config.mk | 3 +++ >> > arch/arm/include/asm/u-boot.h | 9 +++++++++ >> > arch/arm/lib/Makefile | 3 +++ >> > 3 files changed, 15 insertions(+) >> > >> > diff --git a/arch/arm/config.mk b/arch/arm/config.mk >> > index 24b9d7c..a0c89b7 100644 >> > --- a/arch/arm/config.mk >> > +++ b/arch/arm/config.mk >> > @@ -31,6 +31,9 @@ CONFIG_STANDALONE_LOAD_ADDR = 0xc100000 >> > endif >> > endif >> > >> > +# Support generic board on ARM >> > +__HAVE_ARCH_GENERIC_BOARD := y >> > + >> > PLATFORM_CPPFLAGS += -DCONFIG_ARM -D__ARM__ >> > >> > # Choose between ARM/Thumb instruction sets >> > diff --git a/arch/arm/include/asm/u-boot.h >> > b/arch/arm/include/asm/u-boot.h >> > index 2ba98bc..8e7e27b 100644 >> > --- a/arch/arm/include/asm/u-boot.h >> > +++ b/arch/arm/include/asm/u-boot.h >> > @@ -36,6 +36,12 @@ >> > #ifndef _U_BOOT_H_ >> > #define _U_BOOT_H_ 1 >> > >> > +#ifdef CONFIG_SYS_GENERIC_BOARD >> > +/* Use the generic board which requires a unified bd_info */ >> > +#include <asm-generic/u-boot.h> >> > +#else >> > + >> > +#ifndef __ASSEMBLY__ >> > typedef struct bd_info { >> > unsigned int bi_baudrate; /* serial console baudrate */ >> > ulong bi_arch_number; /* unique id for this board */ >> > @@ -49,6 +55,9 @@ typedef struct bd_info { >> > ulong size; >> > } bi_dram[CONFIG_NR_DRAM_BANKS]; >> > } bd_t; >> > +#endif >> > + >> > +#endif /* nCONFIG_SYS_GENERIC_BOARD */ >> >> Typo? > > > The 'n' is intended to mean 'not'. Perhaps I should use ! instead?
I didn't see this use in rest of code; for me it is fine but something to think about. -- Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
