Hi Joe, On 20.03.2013 11:07, Joe Hershberger wrote:
<snip> >>> /* Normal UBI messages */ >>> -#define ubi_msg(fmt, ...) printk(KERN_NOTICE "UBI: " fmt "\n", >>> ##__VA_ARGS__) >>> +#define ubi_msg(fmt, ...) /*printk(KERN_NOTICE "UBI: " fmt "\n", \ >>> + ##__VA_ARGS__)*/ >> >> Hmmm.... > > Yes... this is ugly... I'll clean it up. Thanks. >>> /* UBI warning messages */ >>> #define ubi_warn(fmt, ...) printk(KERN_WARNING "UBI warning: %s: " fmt >>> "\n", \ >>> __func__, ##__VA_ARGS__) >>> diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h >>> index 0af471a..4ab1cbd 100644 >>> --- a/fs/ubifs/ubifs.h >>> +++ b/fs/ubifs/ubifs.h >>> @@ -464,7 +464,7 @@ static inline ino_t parent_ino(struct dentry *dentry) >>> >>> /* Normal UBIFS messages */ >>> #define ubifs_msg(fmt, ...) \ >>> - printk(KERN_NOTICE "UBIFS: " fmt "\n", ##__VA_ARGS__) >>> + /*printk(KERN_NOTICE "UBIFS: " fmt "\n", ##__VA_ARGS__)*/ >> >> ... Not sure again about this silencing. And these "removed" printk's >> are really ugly. > > Agreed... I'll clean it up. > >> Could you please give an example of UBI usage (message logs from "ubi >> create ..., ubi part ..., ubi read ...") without this patch (or complete >> patchset) and with it? So that we see the real difference? > > Here is boot: > > <snip> > NAND: 1024 MiB > MMC: SDHCI: 0 > UBI: attaching mtd1 to ubi0 > UBI: physical eraseblock size: 131072 bytes (128 KiB) > UBI: logical eraseblock size: 129024 bytes > UBI: smallest flash I/O unit: 2048 > UBI: sub-page size: 512 > UBI: VID header offset: 512 (aligned 512) > UBI: data offset: 2048 > UBI: attached mtd1 to ubi0 > UBI: MTD device name: "mtd=2" > UBI: MTD device size: 70 MiB > UBI: number of good PEBs: 560 > UBI: number of bad PEBs: 0 > UBI: max. allowed volumes: 128 > UBI: wear-leveling threshold: 4096 > UBI: number of internal volumes: 1 > UBI: number of user volumes: 4 > UBI: available PEBs: 0 > UBI: total number of reserved PEBs: 560 > UBI: number of PEBs reserved for bad PEB handling: 80 > UBI: max/mean erase counter: 7/1 > In: serial > Out: serial > Err: serial > <snip> > > > And here is a "env save" > > > Saving Environment to UBI... > UBI: mtd1 is detached from ubi0 > UBI: attaching mtd1 to ubi0 > UBI: physical eraseblock size: 131072 bytes (128 KiB) > UBI: logical eraseblock size: 129024 bytes > UBI: smallest flash I/O unit: 2048 > UBI: sub-page size: 512 > UBI: VID header offset: 512 (aligned 512) > UBI: data offset: 2048 > UBI: attached mtd1 to ubi0 > UBI: MTD device name: "mtd=2" > UBI: MTD device size: 70 MiB > UBI: number of good PEBs: 560 > UBI: number of bad PEBs: 0 > UBI: max. allowed volumes: 128 > UBI: wear-leveling threshold: 4096 > UBI: number of internal volumes: 1 > UBI: number of user volumes: 4 > UBI: available PEBs: 0 > UBI: total number of reserved PEBs: 560 > UBI: number of PEBs reserved for bad PEB handling: 80 > UBI: max/mean erase counter: 5/1 > Writing to UBI... done > > > It's pretty out of control. > > With this patch everything that starts with "UBI:" is gone. Only > errors remain (if any). I see. This is definitely helpful for your use-case, env in UBI. But I would like to keep the UBI printf's for all other use cases. Or at least make it configurable. How about adding a switch/define, to optionally disable the UBI output? This seems to be the most flexible option to me. Thanks, Stefan _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
