Dear Adnan Ali,
In message <[email protected]> you
wrote:
> Introduces btrfs file-system to read file from
> volume/sub-volumes with btrload command. This
> implementation has read-only support.
> This btrfs implementation is based on syslinux btrfs
> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
>
> v8: patch re-formated.
> v7: patch re-formated.
> v6: patch re-formated.
What exactly is going on here? Why do you have to go through so many
iterations just reformatting again and again and again?
> +++ b/Makefile
> @@ -257,6 +257,7 @@ endif
> LIBS-$(CONFIG_OF_EMBED) += dts/libdts.o
> LIBS-y += arch/$(ARCH)/lib/lib$(ARCH).o
> LIBS-y += fs/libfs.o \
> + fs/btrfs/libbtrfs.o \
Indentation by TAB only, please.
> + if (argc > 5)
> + strcpy(subvolname, argv[5]);
> + else
> + strcpy(subvolname, "");
Please just to:
subvolname[0] = '\0';
> +void btrfs_type(char num)
> +{
> + switch (num) {
> + case BTRFS_FILE:
> + printf("<FILE> "); break;
> + case BTRFS_DIR:
> + printf("<DIR> "); break;
> + case BTRFS_SYMLNK:
> + printf("<SYM> "); break;
> + default:
> + printf("<UNKNOWN>"); break;
Can you please use puts() instead of print() for all output that does
not really need any formatting?
> + if (ret < 0)
> + low = mid + 1;
> + else if (ret > 0)
> + high = mid;
> + else {
> + *slot = mid;
> +
> + return 0;
> + }
Is this imported code?
CodingStyle says to use braces in all branches if not all branches of
a conditional statement are single line statements. This should be
fixed globally.
> + if (__le64_to_cpu(m1->logical) > __le64_to_cpu(m2->logical))
> +
> + return 1;
> +
> + if (__le64_to_cpu(m1->logical) < __le64_to_cpu(m2->logical))
> +
> + return -1;
Is this imported code? Otherwise: can we drop these empty lines before
the returns?
> + if (ret == 0)/* already in map */
> +
> + return;
Ditto.
> + if (ret == 0)
> + slot++;
> + else if (slot == 0)
> +
> + return -1;
Ditto. etc. This should be fixed globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
To be is to program.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
