[U-Boot] [PATCH v2 2/2] omap_hsmmc: Use -EINVAL not -1 for errors

[Tom Rini]

Signed-off-by: Tom Rini <tr...@ti.com>

---
Changes in v2:
- New patch, use -EINVAL in the driver
---
 drivers/mmc/omap_hsmmc.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
index 8a5dce5..3055ac5 100644
--- a/drivers/mmc/omap_hsmmc.c
+++ b/drivers/mmc/omap_hsmmc.c
@@ -59,13 +59,13 @@ static struct omap_hsmmc_data hsmmc_dev_data[3];
 static int omap_mmc_setup_gpio_in(int gpio, const char *label)
 {
        if (!gpio_is_valid(gpio))
-               return -1;
+               return -EINVAL;
 
        if (gpio_request(gpio, label) < 0)
-               return -1;
+               return -EINVAL;
 
        if (gpio_direction_input(gpio) < 0)
-               return -1;
+               return -EINVAL;
 
        return gpio;
 }
@@ -77,7 +77,7 @@ static int omap_mmc_getcd(struct mmc *mmc)
        if (gpio_is_valid(cd_gpio))
                return gpio_get_value(cd_gpio);
        else
-               return -1;
+               return -EINVAL;
 }
 
 static int omap_mmc_getwp(struct mmc *mmc)
@@ -87,12 +87,12 @@ static int omap_mmc_getwp(struct mmc *mmc)
        if (gpio_is_valid(wp_gpio))
                return gpio_get_value(wp_gpio);
        else
-               return -1;
+               return -EINVAL;
 }
 #else
 static inline int omap_mmc_setup_gpio_in(int gpio, const char *label)
 {
-       return -1;
+       return -EINVAL;
 }
 
 #define omap_mmc_getcd NULL
@@ -401,7 +401,7 @@ static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd 
*cmd,
                mmc_reset_controller_fsm(mmc_base, SYSCTL_SRC);
                return TIMEOUT;
        } else if ((mmc_stat & ERRI_MASK) != 0)
-               return -1;
+               return -EINVAL;
 
        if (mmc_stat & CC_MASK) {
                writel(CC_MASK, &mmc_base->stat);
-- 
1.7.9.5

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot