Hi Minkyu Kang, Please do review the patch set and do let me know if any comments.
Regards, Rajeshwari Shinde On Fri, Mar 22, 2013 at 3:43 AM, Simon Glass <[email protected]> wrote: > Hi Rajeshwari, > > On Thu, Mar 21, 2013 at 4:33 AM, Rajeshwari Shinde > <[email protected]> wrote: >> Changes in V2: >> - Enabled CMD_GPIO as suggested by Simon Glass and >> supported same for EXYNOS5 >> Changes in V3: >> - New patch added to rename S5P GPIO definitions to >> S5P_GPIO >> - GPIO Table added to calculate the base address >> of input gpio bank. >> Changes in V4: >> - To have consistent 0..n-1 GPIO numbering the banks are divided >> into different parts where ever they have holes in them. >> - Function and table to support gpio command moved to s5p-gpio driver >> - Rebased on latest u-boot-samsung tree >> >> Rajeshwari Shinde (3): >> EXYNOS5: Add gpio pin numbering feature >> S5P: Rename GPIO definitions >> EXYNOS5: GPIO: Enable GPIO Command for EXYNOS5 > > I tested this on snow, using: > > # turn on backlight > i2c dev 4; i2c mw 48 f 1; i2c mw 48 15 1; i2c md 48 0 20 > gpio set gpx30 > gpio set gpb20 > > This seems to work fine. > > I also tested that the cros_ec keyboard works, using interrupt 182 > instead of 174) in the FDT: > > ec-interrupt = <&gpio 182 1>; > > So it all looks good to me, thank you. > > Acked-by: Simon Glass <[email protected]> > Tested-by: Simon Glass <[email protected]> > >> >> arch/arm/cpu/armv7/exynos/pinmux.c | 206 +++++++--------- >> arch/arm/include/asm/arch-exynos/cpu.h | 10 +- >> arch/arm/include/asm/arch-exynos/gpio.h | 410 >> ++++++++++++++++++++++++++++-- >> arch/arm/include/asm/arch-s5pc1xx/gpio.h | 26 +- >> board/samsung/goni/goni.c | 4 +- >> board/samsung/origen/origen.c | 8 +- >> board/samsung/smdk5250/smdk5250.c | 24 +-- >> board/samsung/smdkc100/smdkc100.c | 2 +- >> board/samsung/smdkv310/smdkv310.c | 10 +- >> board/samsung/trats/trats.c | 16 +- >> board/samsung/universal_c210/universal.c | 36 ++-- >> drivers/gpio/s5p_gpio.c | 134 +++++++++- >> include/configs/exynos5250-dt.h | 1 + >> 13 files changed, 669 insertions(+), 218 deletions(-) >> >> -- >> 1.7.4.4 >> > > Regards, > Simon > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
