Dear Suriyan Ramasami,
In message <[email protected]> you wrote:
> This is yet another attempt with patch v3.
> Thanks to Wolfgang, Prafulla and Albert for comments, corrections,
> and suggestions.
On addition to the comments already made about how the commit message
should be organized and where comments go, here some additional
remarks:
> + static const u32 kwmpp_config[] = {
...
> + };
> + kirkwood_mpp_conf(kwmpp_config, NULL);
Please always insert a blank line between declarations and code.
> +static void set_leds(u32 leds, u32 blinking)
> +{
> + struct kwgpio_registers *r = (struct kwgpio_registers *)KW_GPIO1_BASE;
> + u32 oe = readl(&r->oe) | BOTH_LEDS;
> + writel(oe & ~leds, &r->oe); /* active low */
Ditto. Please fix globally.
> + u32 bl = readl(&r->blink_en) & ~BOTH_LEDS;
Please never mix declarations and code. Please fix globally.
> diff --git a/board/Seagate/goflexhome/goflexhome.h
> b/board/Seagate/goflexhome/goflexhome.h
> new file mode 100644
> index 0000000..2af2596
> --- /dev/null
> +++ b/board/Seagate/goflexhome/goflexhome.h
What is this file needed for? It appears all this could go into
include/configs/goflexhome.h instead?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
"Science makes godlike -- it is all over with priests and gods when
man becomes scientific. Moral: science is the forbidden as such -- it
alone is forbidden. Science is the *first* sin, the *original* sin.
*This alone is morality.* ``Thou shalt not know'' -- the rest
follows." - Friedrich Nietzsche
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
