On Mon, Apr 01, 2013 at 05:06:16PM +0300, Lubomir Popov wrote: > Signed-off-by: Lubomir Popov <[email protected]>
Thought I had reviewed this already, sorry.
>
> ---
>
> The som5_evb is an evaluation board for the APM-5 - a OMAP5430-based SOM
> (system
> On a Module) designed by MMS and manufactured under license by Jorjin
> Technologies.
Above the '---' so it's in the changelog.
> diff --git a/arch/arm/include/asm/mach-types.h
> b/arch/arm/include/asm/mach-types.h
> index a676b6d..236fa17 100644
> --- a/arch/arm/include/asm/mach-types.h
> +++ b/arch/arm/include/asm/mach-types.h
> @@ -1107,6 +1107,7 @@ extern unsigned int __machine_arch_type;
> #define MACH_TYPE_OMAP5_SEVM 3777
> #define MACH_TYPE_ARMADILLO_800EVA 3863
> #define MACH_TYPE_KZM9G 4140
> +#define MACH_TYPE_SOM5_EVB 4545
Don't touch this file and instead add just this define to your config,
and then #define CONFIG_MACH_TYPE MACH_... If you can't just support
DT-only.
[snip]
> +const struct pad_conf_entry core_padconf_array_non_essential[] = {
> +#if 0
Remove #if 0'd code.
> + gd->bd->bi_arch_number = MACH_TYPE_SOM5_EVB;
CONFIG_MACH_TYPE in your config and you don't need this line
> +#ifdef CONFIG_TWL6035_AUDPWR
> + /* Useful for measuring voltages around the codec.
> + * Works with a TWL604x only.
> + */
/*
* Like this
*/
> +#ifdef CONFIG_I2C_INTERNAL_PULLUPS
> + /* Enable internal I2C-compatible pullups on all buses
> + * TODO: Replace this ugly hardcoding with proper defines (omap.h)
> + * control_smart3io_padconf_0, control_i2c_0
Do please, thanks.
> +#define USB_HOST_HS_CLKCTRL_MASK 0x0100D7C0 /*
> CM_L3INIT_USB_HOST_HS_CLKCTRL */
> +#define USB_TLL_HS_CLKCTRL_MASK 0x00000700 /*
> CM_L3INIT_USB_TLL_HS_CLKCTRL */
Some header please.
> + * TODO: Replace this ugly hardcoding with proper defines
> + */
> + writel(0x0100, 0x4ae0a310);
Again, do please.
> +#define CONFIG_OMAP5430 /* which is in a 5430 */
> +#define CONFIG_SOM5EVB /* working with the SOM5 EVB */
Unused.
> +/* Machine type for Linux */
> +#define CONFIG_MACH_TYPE MACH_TYPE_SOM5_EVB
Ah, since you do have this part already, just update the rest as I had
said.
> +/* Enable all clocks: */
> +/*#define CONFIG_SYS_CLOCKS_ENABLE_ALL*/
> +
> +#define CONFIG_SYS_ENABLE_PADS_ALL /* Enable all PADS for now */
Not allowed.
> +#define CONFIG_SYS_CA15_VECTOR_BASE SRAM_ROM_VECT_BASE
Introduced in the USB patches?
> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, \
> + 57600, 115200}
Please use the fallback table.
> +/* MMC ENV related defines */
> +#define CONFIG_ENV_IS_NOWHERE
> +#ifdef CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_SYS_MMC_ENV_DEV 1 /* SLOT2: eMMC(1) */
> +#define CONFIG_ENV_OFFSET 0xE0000
> +#define CONFIG_CMD_SAVEENV
> +#endif
This is a little un-clear. If MMC will be in mmc like the uEVM, just do
so, and if no storage of env, leave it as NOWHERE.
> +#define CONFIG_CMD_PING /* PING support */
space not tab, fix globally.
> +#define CONFIG_NET_MULTI
Unused.
> + "usbethaddr=9e:77:39:1b:c4:2d\0" \
Not allowed.
> +/*
> + * memtest setup
> + */
> +#define CONFIG_SYS_MEMTEST_START 0xb8000000
> +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START +
> (256 << 20))
> +/* Undef following two for simple mtest */
> +#define CONFIG_SYS_ALT_MEMTEST
> +#define CONFIG_SYS_MEMTEST_SCRATCH 0x81000000
Please see doc/README.memory-test and update as mtest is no longer a
default command.
Thanks!
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
