2013/4/26 Marek Vasut <ma...@denx.de>:
> Dear Kuo-Jung Su,
>
>> From: Kuo-Jung Su <dant...@faraday-tech.com>
>>
>> The Faraday FOTG210 is an OTG chip which could operate
>> as either an EHCI Host or a USB Device as a time.
>>
>> Signed-off-by: Kuo-Jung Su <dant...@faraday-tech.com>
>> CC: Marek Vasut <ma...@denx.de>
>
> Same rambling as for the other patch, bits should have proper names defined in
> the fotg_....h header file.

Got it, thanks

> You should avoid calling
> dcache_enable()/dcache_disable() throughout the driver, why do you need to do
> that? Rather implement proper cacheline flushing/invalidation.
>

Sorry, it's my debug codes in the old days, it would be cleanup later


> Best regards,
> Marek Vasut



--
Best wishes,
Kuo-Jung Su
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to