Dear Jim Lin, [...]
> > > > This is a problem with the struct-based access indeed. I agree with Tom > > it'd be worth to at least try distilling the common part into header > > shared between those three CPUs. > > OK. I will add this into next version of patch. > > > btw you're also adding some kernel-doc-alike annotations to functions, > > why don't you follow kerneldoc style altogether? > > I don't understand what you meant here. > Could you give me an example? Like what I did is wrong or not good. And > what is correct or better one. These kinds of annotations: +/* + * Process a list of nodes, adding them to our list of SDMMC ports. + * + * @param blob fdt blob + * @param node_list list of nodes to process (any <=0 are ignored) + * @param count number of nodes to process + * @return 0 if ok, -1 on error + */ See http://www.denx.de/wiki/U-Boot/CodingStyle at the bottom for the right style. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot